fix: add URL validation in server.go#3368
Open
orbisai0security wants to merge 1 commit intov2ray:masterfrom
Open
fix: add URL validation in server.go#3368orbisai0security wants to merge 1 commit intov2ray:masterfrom
orbisai0security wants to merge 1 commit intov2ray:masterfrom
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
proxy/http/server.go.Vulnerability
V-001proxy/http/server.go:162Description: The HTTP proxy server's handleConnect and handlePlainHTTP functions accept destination addresses derived directly from client-supplied HTTP Host headers and CONNECT targets without validating them against private IP ranges (RFC-1918: 10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16), loopback (127.0.0.0/8), or link-local (169.254.0.0/16) addresses. This allows any attacker with network access to the proxy to use it as an SSRF vector to reach internal services, including cloud provider metadata endpoints.
Changes
proxy/http/server.goVerification
Automated security fix by OrbisAI Security