[totally-not-ai]

Review risk: two-way door — widens one method of the internal-only UIInternals from package-private to public; no change for existing callers.

missing API · flow-server · tools that drive the client side without a browser, such as server-side UI test frameworks

Code that simulates the browser had no way to look at the JavaScript queued for the client without taking all of it. The only public reader marks every invocation as sent, so picking out one call, for example a page reload, dropped all other queued JavaScript. The queue can now be read without changing it.

Risks:

• ⚠️ Public API: UIInternals.getPendingJavaScriptInvocations() is now public; the class is documented as internal-only
• ✅ No behaviour, serialization, threading, security, memory or performance impact; no migration needed

Context. JsCall is documented as the way a driver without a browser recognises calls in the pending queue (definitionType(), methodName(), invokeOn(…)), and containsPendingJsCall can already tell whether such a call is queued, but nothing public could hand the invocation over so it can be acted on and canceled.

• Made UIInternals.getPendingJavaScriptInvocations() public and changed its return type from Stream to List
  • It returns an unmodifiable snapshot of the queue without marking anything as sent and skips canceled invocations, so a caller can handle the calls it simulates, cancel them with PendingJavaScriptInvocation.cancelExecution() (which reports a failure to the call's error handler), and leave the rest for the client; invocations of invisible owners are included
  • Internal callers keep a private stream over the live queue, so isDirty() and the containsPending… checks do not copy it
  • The snapshot means acting on a call, such as canceling it when its error handler queues more JavaScript, no longer fails with ConcurrentModificationException
• Rewrote its Javadoc to describe that contract and dropped the "non-private for testing" comment
• Added a test that cancels one invocation while reading the queue and checks the others, including one queued by the error handler, are still sent

Working on behalf of Artur

[github-actions]

Test Results

 1 670 files  ±0   1 756 suites  ±0   2h 14m 11s ⏱️ - 4m 4s
13 026 tests +1  12 957 ✅ +1  69 💤 ±0  0 ❌ ±0 
13 660 runs  +1  13 591 ✅ +1  69 💤 ±0  0 ❌ ±0 

Results for commit ef966c0. ± Comparison against base commit f04c592.

♻️ This comment has been updated with latest results.

[totally-not-ai]

Replaced both collect(Collectors.toList()) calls in the production dependency warning with Stream.toList(). The lists are only passed to addAll, so returning an unmodifiable list doesn't change anything.

[Artur-]

If we anyway make a copy - wouldn't it be smarter to change the return type to List?

[totally-not-ai]

@Artur- Yes, that's better. getPendingJavaScriptInvocations() now returns an unmodifiable List snapshot. The internal callers (dumpPendingJavaScriptInvocations(), isDirty(), containsPendingJavascript and containsPendingJsCall) use a private stream over the live queue instead, so they don't copy it on every call. The tests now use size() and stream().

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud