Update internal/cliext getters to return their full type#202
Merged
vadimi merged 1 commit intovadimi:mainfrom Mar 3, 2026
Merged
Update internal/cliext getters to return their full type#202vadimi merged 1 commit intovadimi:mainfrom
internal/cliext getters to return their full type#202vadimi merged 1 commit intovadimi:mainfrom
Conversation
internal/cliext getters to return their full type
Owner
|
thanks @mathispesch, that makes sense, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proposed fix for #201. It updates the getters introduced in #194 to return their full type so that later parsing of the expected full types doesn't fail after
urfave/clicalls.Get().With this change, the flags are read correctly (tested with map
--headersand enum value--informat):