Skip to content

Improvements on short press handling #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improvements on short press handling #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions jquery.longpress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,16 @@

// to keep track of how long something was pressed
var mouse_down_time;
var mouse_up_x, mouse_up_y, mouse_down_x, mouse_down_y;
var timeout;
var short_call_time = 0;

// mousedown or touchstart callback
function mousedown_callback(e) {
mouse_down_time = new Date().getTime();
mouse_down_x = e.originalEvent.touches ? e.originalEvent.touches[0].clientX : e.originalEvent.clientX;
mouse_down_y = e.originalEvent.touches ? e.originalEvent.touches[0].clientY : e.originalEvent.clientY;

mouse_down_time = Date.now();
var context = $(this);

// set a timeout to call the longpress callback when time elapses
Expand All @@ -44,19 +49,26 @@

// mouseup or touchend callback
function mouseup_callback(e) {
var press_time = new Date().getTime() - mouse_down_time;
if (press_time < duration) {
// cancel the timeout
clearTimeout(timeout);
mouse_up_x = e.originalEvent.touches ? e.originalEvent.touches[0].clientX : e.originalEvent.clientX;
mouse_up_y = e.originalEvent.touches ? e.originalEvent.touches[0].clientY : e.originalEvent.clientY;

if(Math.abs(mouse_up_x - mouse_down_x) > 100 || Math.abs(mouse_up_y - mouse_down_y) > 100) return;

// call the shortCallback if provided
if (typeof shortCallback === "function") {
shortCallback.call($(this), e);
} else if (typeof shortCallback === "undefined") {
if(Date.now() - mouse_down_time >= duration) return;

clearTimeout(timeout);
if (typeof shortCallback === "function") {

// prevent double-firing for touch devices
// (mouseup, touchend)
if(Date.now() - short_call_time > 50) {
shortCallback.call($(this), e);
}
short_call_time = Date.now();
} else if (typeof shortCallback === "undefined") {
;
} else {
$.error('Optional callback for short press should be a function.');
}
} else {
$.error('Optional callback for short press should be a function.');
}
}

Expand Down