Skip to content

ci: publish to NuGet with the API key again - #657

Merged
currantw merged 1 commit into
valkey-io:release-1.2from
currantw:1.2-revert-nuget-api-key
Nov 18, 2026
Merged

currantw merged 1 commit into
valkey-io:release-1.2from
currantw:1.2-revert-nuget-api-key

Conversation

@currantw

@currantw currantw commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Temporary fix for the 1.2 release. Publishes to NuGet with the NUGET_API_KEY secret again, instead of Trusted
Publishing, until #656 moves publishing to Trusted Publishing with a NuGet service account.

Issue Link

Related to #619 and #656.

Features and Behaviour Changes

⚪ None. CI only.

Limitations

Related Issues

Checklist

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated and all checks pass.
  • CHANGELOG.md, README.md, DEVELOPER.md, and other documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

The Trusted Publishing step from valkey-io#654 failed the 1.2.0-rc4 publish:
`NuGet/login` needs the nuget.org user name of the policy's creator,
not the `valkey` organization, which would tie publishing to a
maintainer's personal account.

As a temporary fix for the 1.2 release, publish with the
`NUGET_API_KEY` secret again. The key is still passed to `dotnet nuget
push` through an environment variable. valkey-io#656 tracks moving to Trusted
Publishing with a NuGet service account.

Signed-off-by: currantw <taylor.curran@improving.com>
@currantw currantw self-assigned this Nov 18, 2026
@currantw currantw added ci CI/CD pipelines and GitHub Actions dev Internal changes like cleanup, refactoring, or developer tools. labels Nov 18, 2026
@currantw
currantw requested a review from yipin-chen November 18, 2026 02:10
@currantw
currantw enabled auto-merge (squash) November 18, 2026 02:11
@currantw
currantw merged commit a0b81ca into valkey-io:release-1.2 Nov 18, 2026
14 checks passed
@currantw
currantw deleted the 1.2-revert-nuget-api-key branch November 18, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD pipelines and GitHub Actions dev Internal changes like cleanup, refactoring, or developer tools.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants