Repository navigation
ci: publish to NuGet with the API key again - #657
Merged
currantw merged 1 commit intoNov 18, 2026
Merged
Conversation
The Trusted Publishing step from valkey-io#654 failed the 1.2.0-rc4 publish: `NuGet/login` needs the nuget.org user name of the policy's creator, not the `valkey` organization, which would tie publishing to a maintainer's personal account. As a temporary fix for the 1.2 release, publish with the `NUGET_API_KEY` secret again. The key is still passed to `dotnet nuget push` through an environment variable. valkey-io#656 tracks moving to Trusted Publishing with a NuGet service account. Signed-off-by: currantw <taylor.curran@improving.com>
currantw
enabled auto-merge (squash)
November 18, 2026 02:11
yipin-chen
approved these changes
Nov 18, 2026
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Temporary fix for the 1.2 release. Publishes to NuGet with the
NUGET_API_KEYsecret again, instead of TrustedPublishing, until #656 moves publishing to Trusted Publishing with a NuGet service account.
Issue Link
Related to #619 and #656.
Features and Behaviour Changes
⚪ None. CI only.
Limitations
Related Issues
Checklist
Tests are added or updated and all checks pass.CHANGELOG.md,README.md,DEVELOPER.md, and other documentation files are updated.mainor releasemain, squash otherwise.