Skip to content

rename common.image to valkey.common.image - #155

Merged
sgissi merged 2 commits into
valkey-io:mainfrom
awoimbee:aw/fix-non-namespaced-helper
Aug 7, 2026
Merged

rename common.image to valkey.common.image#155
sgissi merged 2 commits into
valkey-io:mainfrom
awoimbee:aw/fix-non-namespaced-helper

Conversation

@awoimbee

@awoimbee awoimbee commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Fixes #154

This is a quick fix, I named it valkey.common.image because valkey.image already exists.

Signed-off-by: Arthur Woimbée <arthur.woimbee@gmail.com>
@awoimbee
awoimbee force-pushed the aw/fix-non-namespaced-helper branch from 37c12fc to 1769955 Compare April 2, 2026 12:56
@awoimbee
awoimbee marked this pull request as ready for review April 2, 2026 12:57
@awoimbee

Copy link
Copy Markdown
Contributor Author

bump.
This is a small fix with no negative consequences.
bitnami uses common because their chart is named common (and honestly it should be named something like bitnamicommon) here the chart is named valkey.

Signed-off-by: Silvio Gissi <silvio@gissilabs.com>
@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown

Greptile Summary

This change namespaces the Valkey chart’s shared image helper as valkey.common.image and updates the primary Valkey and metrics-exporter helper calls. Helm v3.19.4 linting and rendering completed successfully with default values, custom primary-image values, and metrics enabled. The tested stale-helper and image-rendering failure paths were disproved: both callers resolve the renamed helper and render the expected image references.

Confidence Score: 5/5

Safe to merge based on successful linting and real Helm rendering of every affected image-helper path.

No review findings remain after Helm rendered the default, custom primary-image, and metrics-enabled configurations with the renamed helper resolving successfully.

Files Needing Attention: No files need additional attention; valkey/templates/_helpers.tpl was directly exercised through its primary and metrics-exporter consumers.

T-Rex T-Rex Logs

What T-Rex did

  • Ran Helm v3.19.4 linting and rendered the chart before and after the helper rename using default values, a custom image registry, and metrics enabled; the chart lint reported 1 chart linted and 0 chart(s) failed, and the rendered outputs included docker.io/valkey/valkey:9.1.1, custom-registry/valkey/valkey:7.0.0, and ghcr.io/oliver006/redis_exporter:v1.79.0.
  • Validated the resolution code paths and workload renders for primary and metrics exporter images, confirming the expected image outputs across default, custom, and exporter images.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Merge branch 'main' into aw/fix-non-name..." | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 12f1b07d-0db0-4f89-a595-73a5d7c06506

📥 Commits

Reviewing files that changed from the base of the PR and between 211e72f and 3fa54c2.

📒 Files selected for processing (1)
  • valkey/templates/_helpers.tpl

📝 Walkthrough

Walkthrough

The chart renames common.image to valkey.common.image and updates the Valkey and metrics exporter image templates to use the renamed helper. Existing image and global registry inputs remain unchanged.

Changes

Image helper namespace

Layer / File(s) Summary
Rename image helper and update callers
valkey/templates/_helpers.tpl
The shared image-rendering template is renamed to valkey.common.image. The Valkey and metrics exporter image templates now include the renamed helper while preserving their image and global configuration inputs.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the primary change: renaming the image helper to a Valkey-specific name.
Description check ✅ Passed The description explains the helper rename, the reason for the change, and links it to issue #154.
Linked Issues check ✅ Passed The renamed helper and updated callers address issue #154 by preventing collisions with identically named helpers in other charts.
Out of Scope Changes check ✅ Passed All changes are limited to renaming the helper and updating its two callers, which matches the linked issue objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sgissi
sgissi merged commit 5c1c434 into valkey-io:main Aug 7, 2026
7 checks passed
pat-s pushed a commit to pat-s/valkey-helm that referenced this pull request Aug 9, 2026
Merging main brought in the rename from valkey-io#155, which removed the common.image
helper that valkey.haproxy.image still called. Rendering the chart with
haproxy.enabled failed outright.

Signed-off-by: pat-s <patrick.schratz@devxy.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

non namespaced template helper can clash (clashes with seaweedfs)

2 participants