added tests for testing full ingestion cycle metadata handling #402
Conversation
Signed-off-by: Nivesh Tuwani <[email protected]>
I, Nivesh Tuwani <[email protected]>, hereby add my Signed-off-by to this commit: 8efa09f Signed-off-by: Nivesh Tuwani <[email protected]> Signed-off-by: Nivesh Tuwani <[email protected]>
Signed-off-by: Nivesh Tuwani <[email protected]>
Signed-off-by: Nivesh Tuwani <[email protected]>
BCathcart
left a comment
BCathcart
left a comment
There was a problem hiding this comment.
Just took a quick peek for now. Let's rebase this on top of the other code once it's merged to clean up the diff.
| # Comprehensive test: Create index with multiple field types for both tokenization and metadata validation | ||
| comprehensive_index = "comprehensive_test_idx" | ||
|
|
||
| # Create index with multiple field types |
There was a problem hiding this comment.
"with multiple text fields"
| "SCHEMA", "title", "TEXT", "content", "TEXT", "score", "NUMERIC" | ||
| ) == b"OK" | ||
|
|
||
| # Insert test data that covers both tokenization and metadata validation |
There was a problem hiding this comment.
Is the data relevant to metadata validation in any way?
|
|
||
| # Validate index is removed from list | ||
| import time | ||
| time.sleep(0.5) # Brief wait for cleanup |
There was a problem hiding this comment.
We should wait for a condition rather than sleep
| "Index with name 'index123' not found", | ||
| ) | ||
|
|
||
| def test_error_handling_metadata_validation(self): |
There was a problem hiding this comment.
Didn't we talk about removing this?
|
Did we merge a PR that already covered some of this? IIRC this was to spit off an end-to-end test. Everything in the test I think is covered by other tests and the end-to-end functionality should be stressed in our upcoming endurance test so I'd suggest we close this as you have more important things to focus on right now. |
KarthikSubbarao
force-pushed
the
fulltext
branch
from
bdd9be5 to
2604515
Compare
3 participants
These tests are for testing metadata handling in full ingestion cylce accross a cluster