Adding tun module as a vellum package#128
Conversation
Updated maintainer and upstream author information, modified package description and URL.
|
Ideally this could complement #116 |
| depmod -a | ||
| modprobe tun | ||
| echo "tun" > /etc/modules-load.d/tun.conf | ||
| sleep 1s |
There was a problem hiding this comment.
Why are you waiting 1 second here before doing a mount-restore? It doesn't look like you are doing any async changes to /etc or / that would require waiting? If there is, perhaps a sync is in order instead of sleep?
There was a problem hiding this comment.
for some reason /home/root/.vellum/bin/mount-restore was erroring out on me with mount: /: mount point is busy, this seemed to solve it. Open to suggestions!
There was a problem hiding this comment.
Try a sync to make sure all changes have been properly written to disk. It could be that it hasn't finished writing. If it's not that, we should track down what is writing to the root partition that shouldn't be, as you have finished your changes already.
There was a problem hiding this comment.
🤔 doesn't mount-restore already run a sync?
vellum/packages/mount-utils/mount-restore
Lines 37 to 39 in a5b1a91
There was a problem hiding this comment.
It worked the three or so times I tried, but might also just be a sometimes works, sometimes doesn't type situation...
There was a problem hiding this comment.
Seems like some kind of orphaned inode issue. This seemed to fix it for me, I ran 50 install / uninstall cycles with no failures:
safe_depmod() {
kver=$(uname -r)
tmp=$(mktemp -d /tmp/depmod.XXXXXX)
depmod -a -o "$tmp"
for f in "$tmp/lib/modules/$kver"/modules.*; do
cat "$f" > "/lib/modules/$kver/$(basename "$f")"
done
rm -rf "$tmp"
}If this is the way we wanna go, should I add to mount-utils?
There was a problem hiding this comment.
as long as mine is the only one that messes with kernel modules it seems like we can just bake it into the specific VELBUILD?
There was a problem hiding this comment.
It probably makes more sense to put into mount-utils so we don't waste time on this again if we add another kernel module
There was a problem hiding this comment.
OK, took a stab at this--added depmod-noorphan to mount-utils and velbuild for tun calls this
Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>
|
@esclee anything else needed for this one? |
|
should be ready for testing with 3.27! |
The depends limit this to 3.26 though? |
|
sigh, I pushed something by mistake and in removing that I made a mistake. Should be good now, sorry |
|
/publish-testing |
|
Packages published to testing repo:
Install with: |
Eeems
left a comment
Eeems
left a comment
There was a problem hiding this comment.
Code changes look good to me, I can install, lsmod, uninstall, lsmod with no issues on the rMPPM and rMPP.
@rmitchellscott quick check on the pure as well?
3 participants
Current plan is for me to build tun modules for ferrari and chiappa as rM releases toolchains and kernel for new OS versions and throw the compiled versions onto a github repo.