Improve Plugson browser handling on Windows.#3500
Open
Funtime60 wants to merge 2 commits into
Open
Conversation
Stop biasing to Google, it didn't even fallback correctly. Now it just opens it.
Fix method of opening browser for plugson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Plugson exe defaults to trying to open 32bit Chrome using hardcoded paths with fallbacks to 64bit Chrome then 32bit and 64bit Firefox in that order. This is ridiculous behavior so I just removed the relevant flags so it always uses the default browser for better reliability.
I found this problem after finding issue #2779 while searching about this bad behavior.