ci: correct pinned action version comments - #778
Closed
dancer wants to merge 1 commit into
Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
the pinned action SHAs on main are correct, but the version comments next to them are not. dependabot bumped the SHAs in #768 and #769 and left the old comments in place, so every pin claims
v6.0.0while resolving to something elseactions/checkout@3d3c42e5v7.0.1v6.0.0actions/setup-node@82076278v7.0.0v6.0.0pnpm/action-setup@0ebf4713v6.0.9v6.0.0CI is unaffected and has been green throughout, since GitHub resolves the SHA and ignores the comment. the point of pinning a SHA with a version comment is that a human can audit what is actually running, and right now the file says v6 while
setup-nodeis on the v7 ESM rewritecomments only, no SHA changes, so nothing about what CI executes changes