[flight-booking-agent] Multi-turn chat and message injection #26
Conversation
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| () => | ||
| new WorkflowChatTransport({ | ||
| api: '/api/chat', | ||
| onChatSendMessage: (response) => { |
There was a problem hiding this comment.
The useChat hook receives resume: false on first render even when a stored session ID exists in localStorage, causing it to start a fresh connection instead of resuming the existing session.
| await writer.write({ type: 'finish' }); | ||
| await writer.close(); |
There was a problem hiding this comment.
The writeStreamClose function acquires a WritableStream writer lock but fails to release it in a try-finally block, and is missing the writer.close() call, causing a resource leak if write() fails
| }); | ||
|
|
||
| // Update messages with the agent's response | ||
| messages.push(...result.messages.slice(messages.length)); |
There was a problem hiding this comment.
Agent responses not properly added to messages on subsequent conversation turns due to incorrect array slicing logic
| { params }: { params: Promise<{ id: string }> } | ||
| ) { | ||
| const { id: runId } = await params; | ||
| const { message } = await req.json(); |
There was a problem hiding this comment.
POST /api/chat/[id] lacks input validation for message field and runId parameter, causing client errors to return 500 instead of 400, exposing internal error details
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
…g added to conversation history in multi-turn conversations Co-authored-by: VaguelySerious <[email protected]>
| const { message: followUp } = await hook; | ||
|
|
||
| // Check for session end signal | ||
| if (followUp === '/done') { |
There was a problem hiding this comment.
Seems like hookPayload.done === true would be cleaner than a magic string, no?
| // All user messages come from stream markers (data-workflow chunks). | ||
| // No deduplication needed - single source of truth. | ||
| const messages = useMemo(() => { | ||
| const result: UIMessage<TMetadata, UIDataTypes>[] = []; | ||
|
|
||
| for (const msg of rawMessages) { | ||
| // Skip user messages from useChat (we only use stream markers) | ||
| if (msg.role === 'user') { | ||
| continue; | ||
| } | ||
|
|
||
| if (msg.role === 'assistant') { | ||
| // Process parts in order, extracting user messages from markers | ||
| let currentAssistantParts: typeof msg.parts = []; | ||
| let partIndex = 0; | ||
|
|
||
| for (const part of msg.parts) { | ||
| if (isUserMessageMarker(part)) { | ||
| const data = part.data; |
There was a problem hiding this comment.
Wait, I'm confused, I thought Variant B didn't use the data markers? How come we can't write msg.role === 'user' chunks directly to the stream?
VaguelySerious
changed the title
|
@TooTallNate Messed up slightly - I had a Variant B that I liked but apparently it didn't work as intended and Claude went back to Variant A, essentially. Since the Docs PR and this PR are aligned in functionality and seem to work well, can you re-review with the idea that we'll merge both, and I'll then follow-up with a smaller polish PR improving on this setup so inject user messages as UIMessageChunks, which requires some changes to DurableAgent ? |
This makes multi-turn session the default for the flight booking app.
The docs PR vercel/workflow#759 also publishes the page on how to do chat session modeling, which includes example code snippets from this PR.
Critically, this PR also removes all
localStorageuse for persistence, with the exception of the last run ID. The durable streams serve as the main durability and storage. To do this, we also specifically persist user messages inside the stream, which wasn't done previouslyAlso see vercel/workflow#739
Screenshots