Skip to content

test alternatives also #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test alternatives also #4679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/search/significance/app_one_significance/models/docv1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"description" : "english model",
"document-count" : 12,
"document-frequencies" : {
"the" : 11,
"usa" : 2,
"hello": 3,
"world": 5,
Expand Down
2 changes: 1 addition & 1 deletion tests/search/significance/docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[
{ "put": "id:test:doc::1", "fields": { "text": "Hello world" } },
{ "put": "id:test:doc::1", "fields": { "text": "Hello the world" } },
{ "put": "id:test:doc::2", "fields": { "text": "Hei verden" } }
]
22 changes: 22 additions & 0 deletions tests/search/significance/significance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,28 @@ def test_significance_searcher_with_multiple_models

def verify_default_significance_for_simple_query
result = search({'yql' => 'select * from sources * where text contains "hello"', 'format' => 'json'}).json
puts "hello => #{result}"
significance_value = result["root"]["children"][0]["fields"]["summaryfeatures"]["term(0).significance"]
# "hello" { frequency: 3, count: 12 }
exp_significance = calculate_legacy_significance(3, 12)
assert_approx(exp_significance, significance_value)

result = search({'yql' => 'select * from sources * where text contains "world"', 'format' => 'json'}).json
puts "world => #{result}"
significance_value = result["root"]["children"][0]["fields"]["summaryfeatures"]["term(0).significance"]
# "world" { frequency: 5, count: 12 }
exp_significance = calculate_legacy_significance(5, 12)
assert_approx(exp_significance, significance_value)

result = search({'yql' => 'select * from sources * where text contains "the"', 'format' => 'json'}).json
puts "the => #{result}"
significance_value = result["root"]["children"][0]["fields"]["summaryfeatures"]["term(0).significance"]
# "the" { frequency: 11, count: 12 }
exp_significance = calculate_legacy_significance(11, 12)
assert_approx(exp_significance, significance_value)

result = search({'yql' => 'select * from sources * where text contains alternatives({"hello":1.0,"world":1.0})', 'format' => 'json'}).json
puts "hello world => #{result}"
significance_value = result["root"]["children"][0]["fields"]["summaryfeatures"]["term(0).significance"]
# "hello" { frequency: 3, count: 12 }
exp_significance = calculate_legacy_significance(3, 12)
Expand Down