Fix wrong path-filename separation on Windows. - #254
Merged
Conversation
s-ludwig
force-pushed
the
windows_watcher_path_fix
branch
from
February 12, 2026 15:09
7973c49 to
5c4443e
Compare
An (invalid) Windows path, such as "foo\\bar:baz" is getting separated at the colon instead of at the backslash by Phobos' dirName/baseName functions. To fix this, this switches to lastIndexOfAny.
s-ludwig
force-pushed
the
windows_watcher_path_fix
branch
from
February 12, 2026 15:23
5c4443e to
01a2ca6
Compare
l-kramer
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An (invalid) Windows path, such as "foo\bar:baz" is getting separated at the colon instead of at the backslash by Phobos' dirName/baseName functions. To fix this, this switches to lastIndexOfAny.