Skip to content

Conversation

@killmenot
Copy link

@killmenot killmenot commented May 14, 2018

Hi,

The following PR contains:

  • move winston to peer dependencies (it's the only breaking change of this PR but most users of have winston installed anyway)
  • fix an issue when first log not added to queue (state = NOT_INITIALIZED)
  • add editor config
  • add jshint
  • add tests
  • add coverage (you can integrate it with https://coveralls.io/ via travis, I can submit PR if needed)
  • add debug (DEBUG=winston-node-monitor-ui allow to see debug information)
  • bump deps (most important socket.io-client to fix https://nodesecurity.io/advisories/534)
  • lock peerDependencies to ^2.0.0 because (I'll pull 3.x version soon also)

Also, I'd recommend you to keep 2.x branch in the repo and release 2.0.0 version to keep support of winston 2.x and later switch main branch (master) to support winston 3.x only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant