Skip to content

Bump PyJWT to 2.12.1#574

Merged
vimalloc merged 1 commit into
vimalloc:mainfrom
oomichi-melco:oomichi/update-pyjwt
May 8, 2026
Merged

Bump PyJWT to 2.12.1#574
vimalloc merged 1 commit into
vimalloc:mainfrom
oomichi-melco:oomichi/update-pyjwt

Conversation

@oomichi-melco
Copy link
Copy Markdown
Contributor

Close: #573

@vimalloc
Copy link
Copy Markdown
Owner

I'll take a look at these errors and get this merge in. ty

@oomichi-melco
Copy link
Copy Markdown
Contributor Author

oomichi-melco commented Apr 27, 2026

I'll take a look at these errors and get this merge in. ty

Thank you so much.
The error is

mypy: commands[0]> mypy flask_jwt_extended/ tests/
flask_jwt_extended/tokens.py:103: error: Argument "options" has incompatible type "dict[str, bool]"; expected "Options | None"  [arg-type]
Found 1 error in 1 file (checked 30 source files)

The corresponding lines are

    decoded_token = jwt.decode(
        encoded_token,
        secret,
        algorithms=algorithms,
        audience=audience,
        issuer=issuer,
        leeway=leeway,
        options=options,
    )  

That might be due to imcompatible change of pyjwt.

@oomichi-melco
Copy link
Copy Markdown
Contributor Author

@vimalloc
Could you take a look at this pull request again?
I might fix the problem at CI.

@vimalloc
Copy link
Copy Markdown
Owner

vimalloc commented May 4, 2026

Yes, thank you for pinging me. This week has been crazy and this got away from me.

vimalloc added a commit that referenced this pull request May 4, 2026
vimalloc added a commit that referenced this pull request May 4, 2026
Update python versions to include currently active versions

There was a PyJWT mypy breaking causing issues :( 
I pulled the fix from @oomichi-melco (#574) into to resolve it.
@vimalloc
Copy link
Copy Markdown
Owner

vimalloc commented May 4, 2026

I fixex the python/mypy issues in a separate PR. If you pull main you should be good to go now!

I had to pull your PyJWT mypy fix into that PR or it was failing when trying to install the newest PyJWT version via install_requires. It's not ideal that a non-major version bump causes a breaking change, but it is what it is.

Thanks for figuring out that mypy issue! I pulled your code into that PR and credited you with it.

Cheers.

@oomichi-melco oomichi-melco force-pushed the oomichi/update-pyjwt branch from d0fe710 to b770686 Compare May 7, 2026 00:16
@oomichi-melco
Copy link
Copy Markdown
Contributor Author

I fixex the python/mypy issues in a separate PR. If you pull main you should be good to go now!

I had to pull your PyJWT mypy fix into that PR or it was failing when trying to install the newest PyJWT version via install_requires. It's not ideal that a non-major version bump causes a breaking change, but it is what it is.

Thanks for figuring out that mypy issue! I pulled your code into that PR and credited you with it.

Cheers.

@vimalloc
Thanks for doing that.
After rebasing this pull request on the latest main branch, this becomes simple :-)

@vimalloc vimalloc merged commit 9bf8d35 into vimalloc:main May 8, 2026
14 checks passed
@oomichi-melco oomichi-melco deleted the oomichi/update-pyjwt branch May 8, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyjwt needs to be updated to version 2.12.0 or higher

2 participants