Fix/multi network#9
Open
0xpApaSmURf wants to merge 5 commits into
Open
Conversation
pedroapfilho
approved these changes
Sep 13, 2023
ra-phael
reviewed
Sep 13, 2023
Contributor
There was a problem hiding this comment.
I don't think we need these tokens defined, do we?
Contributor
Author
There was a problem hiding this comment.
We don't but every logical change I made seemed not to make any sense which is why I've rolled back to old subgraph stuff. Right now it works and there's no good reason why, so good reasons seem worth abandoning for now :)
| updatePoolHourData(event) | ||
|
|
||
| // update token prices | ||
| if (!token0 || !token1) return |
Contributor
There was a problem hiding this comment.
Should we throw if it's falsy?
Contributor
Author
There was a problem hiding this comment.
Same as above, this is code that currently works for Uniswap and for us, and that's a nice place to be 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually removes multinetwork support and splits deployments into two.
This repo is now responsible for
mainnetdeployments.The phlox repo is now responsible for
optimism-goerlideployments.