Skip to content

[Bugfix][Helm] Preserve zero initial delays for engine probes - #1158

Open
git-jxj wants to merge 1 commit into
vllm-project:mainfrom
git-jxj:fix/helm-probe-zero-delay
Open

git-jxj wants to merge 1 commit into
vllm-project:mainfrom
git-jxj:fix/helm-probe-zero-delay

Conversation

@git-jxj

@git-jxj git-jxj commented Oct 19, 2026

Copy link
Copy Markdown

The serving-engine probe helper replaces an explicit initialDelaySeconds: 0 with 15. This silently overrides configurations that request no initial delay for startup, liveness, or readiness checks.

Check whether the field is present so zero is preserved and omitted values still default to 15. Add chart regression coverage for zero, positive, and omitted delays, and increment the chart patch version.

Validation: helm unittest helm passes all 25 suites and 148 tests. Applicable pre-commit hooks and helmlint pass. The zero-delay case fails against the unmodified helper for all three probes.


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit.
  • Try to classify PRs for easy understanding of the type of changes.

Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Helm chart to correctly handle and preserve an initialDelaySeconds value of 0 for startup, liveness, and readiness probes. Previously, using the default function caused 0 to be overridden by the default value of 15. This has been resolved by using the ternary and hasKey functions instead. Additionally, a new test suite has been added to verify this behavior under various scenarios, and the chart version has been bumped to 0.1.14. There are no review comments, and I have no additional feedback to provide.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant