Repository navigation
Conversation
Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>
git-jxj
requested review from
ApostaC,
YuhanLiu11 and
ruizhang0101
as code owners
October 19, 2026 13:35
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Helm chart to correctly handle and preserve an initialDelaySeconds value of 0 for startup, liveness, and readiness probes. Previously, using the default function caused 0 to be overridden by the default value of 15. This has been resolved by using the ternary and hasKey functions instead. Additionally, a new test suite has been added to verify this behavior under various scenarios, and the chart version has been bumped to 0.1.14. There are no review comments, and I have no additional feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serving-engine probe helper replaces an explicit
initialDelaySeconds: 0with 15. This silently overrides configurations that request no initial delay for startup, liveness, or readiness checks.Check whether the field is present so zero is preserved and omitted values still default to 15. Add chart regression coverage for zero, positive, and omitted delays, and increment the chart patch version.
Validation:
helm unittest helmpasses all 25 suites and 148 tests. Applicable pre-commit hooks andhelmlintpass. The zero-delay case fails against the unmodified helper for all three probes.-swhen doinggit commit.