test: remove duplicate TestHandleHealth test#347
Conversation
TestHandleHealth and TestHandleHealthLive were identical tests for /health/live endpoint. Removed TestHandleHealth, keeping the more descriptively named TestHandleHealthLive. Fixes volcano-sh#344 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Removes a duplicate router health-check unit test in pkg/router/handlers_test.go, keeping the more descriptive TestHandleHealthLive to avoid redundant coverage of the /health/live endpoint.
Changes:
- Deleted
TestHandleHealth, which was identical toTestHandleHealthLive. - Retained
TestHandleHealthLiveas the canonical test for/health/live.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 47.57% 49.12% +1.55%
==========================================
Files 30 30
Lines 2819 2858 +39
==========================================
+ Hits 1341 1404 +63
+ Misses 1338 1301 -37
- Partials 140 153 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FAUST-BENCHOU
left a comment
FAUST-BENCHOU
left a comment
There was a problem hiding this comment.
dont forget your DCO
Summary
Removed duplicate test
TestHandleHealthwhich was identical toTestHandleHealthLive— both tested the/health/liveendpoint with the same logic.Kept
TestHandleHealthLiveas it has a more descriptive name.Test plan
go test ./pkg/router/...Fixes #344
🤖 Generated with Claude Code