fix(reindex): surface indexed/skipped file counts in maintenance reindex response (#1706)#2623
Open
yeyitech wants to merge 1 commit into
Open
fix(reindex): surface indexed/skipped file counts in maintenance reindex response (#1706)#2623yeyitech wants to merge 1 commit into
yeyitech wants to merge 1 commit into
Conversation
…dex response (volcengine#1706) Previously reindex returned a generic success even when 0 files were actually indexed (e.g. directory only contained skipped .overview.md). Now the response reports how many files were indexed and skipped so callers can detect no-op reindexes. Closes volcengine#1706
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.overview.md).Test plan
.overview.md-> response showsindexed_files: 0,skipped_files: 1.indexed_files.Closes #1706