Skip to content

fix(reindex): surface indexed/skipped file counts in maintenance reindex response (#1706)#2623

Open
yeyitech wants to merge 1 commit into
volcengine:mainfrom
yeyitech:fix/1706-reindex-zero-vector-report
Open

fix(reindex): surface indexed/skipped file counts in maintenance reindex response (#1706)#2623
yeyitech wants to merge 1 commit into
volcengine:mainfrom
yeyitech:fix/1706-reindex-zero-vector-report

Conversation

@yeyitech

Copy link
Copy Markdown
Contributor

Summary

  • Surfaces indexed-file and skipped-file counts in the maintenance reindex API response so callers can detect no-op reindexes (e.g. a directory that only contains a skipped .overview.md).
  • Previously the endpoint returned a generic success regardless of actual work performed.

Test plan

  • Reindex a URI with only .overview.md -> response shows indexed_files: 0, skipped_files: 1.
  • Reindex a URI with real content files -> response shows non-zero indexed_files.
  • Existing reindex callers continue to work (added fields are additive).

Closes #1706

…dex response (volcengine#1706)

Previously reindex returned a generic success even when 0 files were
actually indexed (e.g. directory only contained skipped .overview.md).
Now the response reports how many files were indexed and skipped so
callers can detect no-op reindexes.

Closes volcengine#1706
@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

1706 - Partially compliant

Compliant requirements:

  • Return informative response with indexed/skipped file counts

Non-compliant requirements:

  • (empty)

Requires further human verification:

  • (empty)
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 90
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Broken Test Assertion

The existing test assertion at line 1411 does an exact equality check on the reindex result, which now includes additional fields (indexed_files, skipped_files, etc.), causing the test to fail.

assert result == {"status": "completed", "uri": "viking://resources/demo"}

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Reindex returns success with zero vectors when directory only contains .overview.md

1 participant