Skip to content

fix(parse): use safe_extract_zip for UnderstandingAPI zip download to close Zip Slip #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r266-tech wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix(parse): use safe_extract_zip for UnderstandingAPI zip download to close Zip Slip #2634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openviking/parse/understanding_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from openviking.parse.base import NodeType, ParseResult, ResourceNode
from openviking.parse.parsers.base_parser import BaseParser
from openviking.storage.viking_fs import get_viking_fs
from openviking.utils.zip_safe import safe_extract_zip
from openviking_cli.utils.logger import get_logger

logger = get_logger(__name__)
Expand Down Expand Up @@ -460,7 +461,7 @@ async def _unpack_zip_to_temp_dir(self, zip_path: Path, resource_name: str) -> s

with tempfile.TemporaryDirectory() as extract_dir:
with zipfile.ZipFile(zip_path, "r") as zf:
zf.extractall(extract_dir)
safe_extract_zip(zf, extract_dir)
extract_path = Path(extract_dir)
items = [p for p in extract_path.iterdir() if p.name not in {".", ".."}]
if len(items) == 1 and items[0].is_dir():
Expand Down
Loading