Skip to content

fix compiler warning in elixir 1.20 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slashmili wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix compiler warning in elixir 1.20 #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/x509/certificate.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@
@doc false
# Returns a random serial number as an integer
def random_serial(size) do
<<i::unsigned-size(size)-unit(8)>> = :crypto.strong_rand_bytes(size)
<<i::unsigned-size(^size)-unit(8)>> = :crypto.strong_rand_bytes(size)

Check failure on line 371 in lib/x509/certificate.ex

View workflow job for this annotation

GitHub Actions / test (1.12, 24.3) 

** (CompileError) lib/x509/certificate.ex:371: cannot use ^size outside of match clauses

Check failure on line 371 in lib/x509/certificate.ex

View workflow job for this annotation

GitHub Actions / test (1.14, 25.3) 

** (CompileError) lib/x509/certificate.ex:371: cannot use ^size outside of match clauses

Check failure on line 371 in lib/x509/certificate.ex

View workflow job for this annotation

GitHub Actions / test (1.13, 25.0) 

** (CompileError) lib/x509/certificate.ex:371: cannot use ^size outside of match clauses
Copy link
Copy Markdown
Owner

@voltone voltone Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the use of the pin operator recommended in Elixir 1.20 is not supported by Elixir <=1.14. We can sidestep the issue altogether by using :binary.decode_unsigned/1.

i
end

Expand Down
Loading