feat[array]: pushdown struct validity on write #5923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-isaacs
force-pushed
the
ji/struct-val-push-downn
branch
from
5a5ac8f to
551425d
Compare
Merging this PR will degrade performance by 33.7%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | u16_FoR[10M] |
6.5 µs | 9.7 µs | -33.7% |
| ⚡ | Simulation | canonical_into_non_nullable[(10000, 100, 0.01)] |
3 ms | 2.1 ms | +37.96% |
| ⚡ | Simulation | canonical_into_non_nullable[(10000, 100, 0.0)] |
2.7 ms | 1.9 ms | +42.61% |
| ⚡ | Simulation | canonical_into_non_nullable[(10000, 100, 0.1)] |
4.5 ms | 3.7 ms | +22.33% |
| ❌ | Simulation | canonical_into_nullable[(10000, 10, 0.0)] |
445.4 µs | 528.7 µs | -15.75% |
| ❌ | Simulation | canonical_into_nullable[(10000, 100, 0.0)] |
4.1 ms | 4.9 ms | -16.39% |
| ⚡ | Simulation | into_canonical_non_nullable[(10000, 100, 0.01)] |
3 ms | 2.2 ms | +36.73% |
| ⚡ | Simulation | into_canonical_non_nullable[(10000, 100, 0.1)] |
4.6 ms | 3.7 ms | +21.46% |
| ⚡ | Simulation | into_canonical_non_nullable[(10000, 100, 0.0)] |
2.7 ms | 1.9 ms | +41.84% |
| ⚡ | Simulation | into_canonical_nullable[(10000, 100, 0.0)] |
5.2 ms | 4.4 ms | +18.5% |
Comparing ji/struct-val-push-downn (a43054c) with develop (a095ca7)
Footnotes
-
1290 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
joseph-isaacs
changed the title
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/struct-val-push-downn
branch
from
5b15206 to
003256a
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
a10y
reviewed
Jan 23, 2026
| #[derive(Clone, prost::Message)] | ||
| pub struct StructMetadata { | ||
| /// If true, child validity is a superset of struct validity (validity was pushed down). | ||
| /// For nullable children, their validity already includes struct nulls. For non-nullable |
Contributor
There was a problem hiding this comment.
why only push this into null children why not all ?
Contributor
Author
There was a problem hiding this comment.
It is unneeded (free to add on read) and changes the dtype of the child.
a10y
reviewed
Jan 23, 2026
a10y
reviewed
Jan 23, 2026
a10y
reviewed
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new validity_pushed_down field to struct
Intersect struct validity with nullable children allowing us to skip validity intersection in read.
This is tracked with metadata on struct array/layout.