Skip to content

Conversation

@asubiotto
Copy link
Contributor

Previously when filtering a list array, we could create a mask longer than the sliced elements range, causing a "Filter mask length mismatch" panic.

@asubiotto asubiotto requested a review from gatesn January 23, 2026 08:48
@asubiotto asubiotto added the changelog/fix A bug fix label Jan 23, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 1262 untouched benchmarks
⏩ 1290 skipped benchmarks1


Comparing asubiotto/filterslice (f626cc1) with develop (c6161f6)

Open in CodSpeed

Footnotes

  1. 1290 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

asubiotto and others added 2 commits January 23, 2026 16:07
Previously when filtering a list array, we could create a mask longer than the
sliced elements range, causing a "Filter mask length mismatch" panic.

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
@a10y a10y force-pushed the asubiotto/filterslice branch from cd1fc75 to f626cc1 Compare January 23, 2026 21:08
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@a10y a10y enabled auto-merge (squash) January 23, 2026 21:08
@a10y a10y merged commit 1e5cb77 into develop Jan 23, 2026
45 of 46 checks passed
@a10y a10y deleted the asubiotto/filterslice branch January 23, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants