-
Notifications
You must be signed in to change notification settings - Fork 121
feat[cuda]: dict decimal take #6129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merging this PR will degrade performance by 45.31%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | u16_FoR[10M] |
6.5 µs | 11.4 µs | -43.44% |
| ❌ | WallTime | u8_FoR[10M] |
5.6 µs | 10.2 µs | -45.31% |
Comparing ji/dict-decimal-value (4ca28f5) with develop (a095ca7)
Footnotes
-
1290 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
6e747d7 to
2f3d1d4
Compare
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
2f3d1d4 to
cb5a418
Compare
a10y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
No description provided.