Skip to content

Conversation

@anasik
Copy link
Contributor

@anasik anasik commented May 16, 2022

Currently, if users do this:

const result = await client.MyFunction(args)
The result will be equal to an array containing result, rawResponse, soapHeader, rawRequest, mtomAttachments. And if they want just the parsed JSON response they have to do result[0].

This is fine. But if we make promisify return an object instead of an array, they could do this:

const { result } = await client.MyFunction(args)

anasik added 2 commits May 16, 2022 17:30
Currently, if users do this:
> const result =  await client.MyFunction(args) 
The result will be equal to an array containing result, rawResponse, soapHeader, rawRequest, mtomAttachments. And if they want just the parsed JSON response they have to do result[0].

This is fine. But if we make promisify return an object instead of an array, they could do this:
> const { result } =  await client.MyFunction(args)
@smokhov
Copy link
Contributor

smokhov commented Apr 5, 2025

@w666 -- could you please rebase this to run the checks?

@w666
Copy link
Collaborator

w666 commented Dec 1, 2025

I reviewed this again, while I think this may provide some benefits, it will break it for many users of this library, unfortunately I can't do this.

@w666 w666 closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants