Skip to content

Fix error handling by raising ReadWriteMemoryError in multiple method… #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MillhioreBT wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix error handling by raising ReadWriteMemoryError in multiple method… #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ReadWriteMemory/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def read(self, lp_base_address: int) -> Any:
self.error_code = self.get_last_error()
error = {'msg': str(error), 'Handle': self.handle, 'PID': self.pid,
'Name': self.name, 'ErrorCode': self.error_code}
ReadWriteMemoryError(error)
raise ReadWriteMemoryError(error)
Copy link

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ReadWriteMemoryError constructor appears to expect a string message, but a dictionary is being passed. This will likely result in an unhelpful error representation. Consider passing error['msg'] instead of the entire error dictionary, or update the exception class to properly handle dictionary input.

Copilot uses AI. Check for mistakes.

def readString(self, lp_base_address: int, length: int) -> Any:
"""
Expand All @@ -169,7 +169,7 @@ def readString(self, lp_base_address: int, length: int) -> Any:
self.error_code = self.get_last_error()
error = {'msg': str(error), 'Handle': self.handle, 'PID': self.pid,
'Name': self.name, 'ErrorCode': self.error_code}
ReadWriteMemoryError(error)
raise ReadWriteMemoryError(error)

def readByte(self, lp_base_address: int, length: int = 1) -> List[hex]:
"""
Expand All @@ -191,7 +191,7 @@ def readByte(self, lp_base_address: int, length: int = 1) -> List[hex]:
self.error_code = self.get_last_error()
error = {'msg': str(error), 'Handle': self.handle, 'PID': self.pid,
'Name': self.name, 'ErrorCode': self.error_code}
ReadWriteMemoryError(error)
raise ReadWriteMemoryError(error)

def readDouble(self, lp_base_address: int) -> Any:
"""
Expand All @@ -215,7 +215,7 @@ def readDouble(self, lp_base_address: int) -> Any:
self.error_code = self.get_last_error()
error = {'msg': str(error), 'Handle': self.handle, 'PID': self.pid,
'Name': self.name, 'ErrorCode': self.error_code}
ReadWriteMemoryError(error)
raise ReadWriteMemoryError(error)

def write(self, lp_base_address: int, value: int) -> bool:
"""
Expand All @@ -240,7 +240,7 @@ def write(self, lp_base_address: int, value: int) -> bool:
self.error_code = self.get_last_error()
error = {'msg': str(error), 'Handle': self.handle, 'PID': self.pid,
'Name': self.name, 'ErrorCode': self.error_code}
ReadWriteMemoryError(error)
raise ReadWriteMemoryError(error)

def writeDouble(self, lp_base_address: int, value: float) -> bool:
"""
Expand All @@ -265,7 +265,7 @@ def writeDouble(self, lp_base_address: int, value: float) -> bool:
self.error_code = self.get_last_error()
error = {'msg': str(error), 'Handle': self.handle, 'PID': self.pid,
'Name': self.name, 'ErrorCode': self.error_code}
ReadWriteMemoryError(error)
raise ReadWriteMemoryError(error)

def writeString(self, lp_base_address: int, string: str) -> bool:
"""
Expand All @@ -290,7 +290,7 @@ def writeString(self, lp_base_address: int, string: str) -> bool:
self.error_code = self.get_last_error()
error = {'msg': str(error), 'Handle': self.handle, 'PID': self.pid,
'Name': self.name, 'ErrorCode': self.error_code}
ReadWriteMemoryError(error)
raise ReadWriteMemoryError(error)

def writeByte(self, lp_base_address: int, bytes: List[hex]) -> bool:
"""
Expand All @@ -314,7 +314,7 @@ def writeByte(self, lp_base_address: int, bytes: List[hex]) -> bool:
self.error_code = self.get_last_error()
error = {'msg': str(error), 'Handle': self.handle, 'PID': self.pid,
'Name': self.name, 'ErrorCode': self.error_code}
ReadWriteMemoryError(error)
raise ReadWriteMemoryError(error)

class ReadWriteMemory:
"""
Expand Down