Skip to content

Conversation

@nolankramer
Copy link
Contributor

@nolankramer nolankramer commented Oct 2, 2025

Pull Request Template

Description

Change to increase the extensibility of DescriptorSetLayout support in vsg.

Adds VkDescriptorSetLayoutCreateFlags to enable customization of layout creation.

Adds DescriptorSetLayoutBindingFlags to enable customization of layout binding creation.

Adds an void addBinding(...) function to help users add bindings with corresponding flags.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nolankramer
Copy link
Contributor Author

nolankramer commented Oct 2, 2025

I've opened this PR to essentially add the basis of increasing the extensibility of vsg::DescriptorSetLayout.

I probably won't have time to update code in vsgExamples or other places in vsg to take advantage of this new feature

@nolankramer nolankramer force-pushed the master branch 2 times, most recently from 601613d to 0dc5f90 Compare November 18, 2025 06:15
{
Object::read(input);

createFlags = input.readValue<uint32_t>("createFlags");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break backwards compatibility of the .vsgt/.vsgb file format. The way this will need to be resolved is by adding file version checks.

bindings(descriptorSetLayoutBindings),
createFlags(0)
{
bindingFlags.resize(bindings.size(), 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is appropriate. You have a check against an empty bindingFlags vector in the DescriptorSetLayout::Implementation::Implementation() so I don't see the need to fill in a blank array. I think it better to just implement these method as before and let uses explictly fill in the bindingFlags if they so wish.

@robertosfield robertosfield merged commit 5458739 into vsg-dev:master Nov 27, 2025
@robertosfield
Copy link
Collaborator

I have merged this PR with fixes to code passing the VkDescriptorSetLayoutBindingFlagsCreateInfo, versioning of serailization so that old .vsgt/.vsgb files are loadable. The changes I've made are: 8e3dc26.

I don't have proper test for new capability so an addition test/example for vsgExamples would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants