Add allowed namespaces to vshngarage#682
Merged
Merged
Conversation
This uses the GarageReferenceGrant to restrict where GarageKeys and GarageBuckets can be provisioned.
3 tasks
Contributor
|
mikeshootzz
requested review from
a team,
Kidswiss,
TheBigLee,
mdnix and
zugao
and removed request for
a team
TheBigLee
approved these changes
May 21, 2026
zugao
approved these changes
May 21, 2026
zugao
reviewed
May 21, 2026
| } | ||
|
|
||
| if err := applyAllowedNamespaces(values, svc.Config.Data["garageAllowedNamespaces"]); err != nil { | ||
| return runtime.NewFatalResult(err) |
Collaborator
There was a problem hiding this comment.
Can this fatal error return too early and try to delete managed resources?
Contributor
Author
There was a problem hiding this comment.
It doesn't, no. if we'd throw an error instead of a fatal we would have no allowed namespaces, which means no reference grant would be created. Throwing a fatal doesn't return early, it just halts the reconciliation, which in this case is what we want.
Contributor
|
Contributor
Author
|
/merge |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syn-appcatis included by default so AppCat can provision the buckets as normalChecklist
/mergecomment.Component PR: vshn/component-appcat#1193