docs: align SSR StackBlitz examples with button markup - #3469
Open
SatvikMishra08 wants to merge 2 commits into
Open
SatvikMishra08 wants to merge 2 commits into
SatvikMishra08 wants to merge 2 commits into
Conversation
The SSR guide shows a <button> counter, but the linked StackBlitz projects still used a <div>. Vendor the examples under examples/ and point the guide links at GitHub-backed StackBlitz URLs so the markup stays in sync.
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Add examples/ssr-example and examples/ssr-example-basic with <button> markup matching the SSR guide, so the GitHub-backed StackBlitz links resolve after merge.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3332.
The SSR guide uses a
<button>counter, but the linkedvue-ssr-example/vue-ssr-example-basicStackBlitz templates still rendered a<div>. This PR:examples/ssr-exampleandexamples/ssr-example-basic(button markup matching the guide)vuejs/docsso the examples stay reviewable in-repoUntil this merges, reviewers can open the fork tree via StackBlitz:
https://stackblitz.com/github/SatvikMishra08/vuejs-docs/tree/docs/3332-ssr-stackblitz-button/examples/ssr-example
AI disclosure
AI-assisted extraction/fix of the StackBlitz templates; I verified
app.jsuses<button>to match the guide.