fix(tutorial): fetch todo data on mount instead of in setup - #3472
Open
hermanrous wants to merge 1 commit into
Open
hermanrous wants to merge 1 commit into
hermanrous wants to merge 1 commit into
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Problem
Tutorial step 10's composition-API variant calls
fetchData()directly insidesetup(). The request fires during server-side rendering and the result is discarded — an SSR-unsafe pattern that users may copy into production. The step description already says todos are fetched "on component mount", and the Options API variant usesmounted().Proposed Solution
Move the initial fetch into
onMounted()in bothApp/composition.jsand_hint/App/composition.js, matching the existing step description and the Options API variant. Browser behavior is unchanged (data loads immediately after mount), and the watch-based todo filtering is unaffected.Additional Information
Closes #2416.