fix(Button,Pagination): activate non-native as-div/span elements on Enter/Space#632
Open
sridhar-3009 wants to merge 2 commits into
Open
fix(Button,Pagination): activate non-native as-div/span elements on Enter/Space#632sridhar-3009 wants to merge 2 commits into
sridhar-3009 wants to merge 2 commits into
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ButtonRootandPaginationItemrender withrole="button"andtabindex="0"when used as non-native elements (as="div",as="span"), but have noonKeydownhandler. Native<button>activates on Enter/Space automatically;<div role="button">does not. Keyboard-only users can focus these elements but cannot activate them.Closes #616.
Solution
Added an
onKeydownhandler to each component that firesonClick()/select()onEnterorSpace. The handler is only wired whenas !== 'button'— native buttons keep their default behavior untouched.Note:
ToggleRootalready had keyboard handling and was not changed.