This repository was archived by the owner on Dec 2, 2019. It is now read-only.
Fix backspace key handling on the SFML OpenGL2 platform demo#932
Open
bharadwaj-raju wants to merge 2 commits intovurtun:masterfrom
Open
Fix backspace key handling on the SFML OpenGL2 platform demo#932bharadwaj-raju wants to merge 2 commits intovurtun:masterfrom
bharadwaj-raju wants to merge 2 commits intovurtun:masterfrom
Conversation
Previously, backspace characters would be passed directly to nk_input_unicode, resulting in backspace not working and instead simply inserting ASCII backspace '\b' into the text. This fixes it by filtering out '\b' in the event handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, backspace characters would be passed directly to nk_input_unicode, resulting in backspace not working and instead simply inserting ASCII backspace '\b' into the text.
This fixes it by filtering out '\b' (ASCII code 8) in the event handler. Now backspace works as expected.