You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found a Windows regression in the new permission test (tests/mcpHttp.test.mjs:142). I built this PR and ran node --test tests/mcpHttp.test.mjs on Windows / Node 24.19.0: 2 passed, 1 failed, with 438 !== 384 (reported mode 0666 rather than 0600). Windows does not implement the Unix owner/group/other permission model through fchmodSync, so this assertion fails even when config generation succeeds.
Please make the mode assertion platform-aware, retain the 0600 check on POSIX, and avoid describing fchmodSync as providing owner-only ACLs on Windows. The JSON and credential transport assertions should still run on every platform. Leaving this PR open until the newly introduced failure is addressed.
Addressed the Windows test regression. The 0600 mode assertion now runs only on non-Windows platforms, while the JSON and credential-transport assertions still run everywhere. The changelog now scopes the owner-only permission claim to POSIX systems.
Verification: node --test tests/mcpHttp.test.mjs (3 passed) and npm test (198 passed).
This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm run build— passednode --test tests/mcpHttp.test.mjs— passed (3 tests)npm test— passed (198 tests)git diff --check— passedRisk
0600, while Windows retains its platform-native permission behavior.This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.