-
Notifications
You must be signed in to change notification settings - Fork 381
Proofread docs in the /contributing directory #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Proofread docs in the /contributing directory #1718
Conversation
|
|
||
| Please submit your patches using the well-known GitHub pull-request against our | ||
| repositories found in the VyOS GitHub organisation at https://github.com/vyos | ||
| 6. Push to your fork and create a GitHub pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we recommend making pull requests against the current branch?
| * Python: Tabs **shall not** be used. Every indentation level should be 4 spaces | ||
| * XML: Tabs **shall not** be used. Every indentation level should be 2 spaces | ||
| * **Python**: Use 4 spaces per indentation level. Tabs **must not** be used. | ||
| * **XML**: Use 2 spaces per indentation level. Tabs **must not** be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other languages commonly used in VyOS that currently have internal coding guidelines? For example, C is used extensively in VyOS, what guidelines are there for C programming at VyOS?
Change Summary
Edited content in the
docs/contributingdirectory to align with the Microsoft Writing Style Guidetesting.rstbuild-vyos.rstupstream-packages.rstcla.rstdebugging.rstdevelopment.rstRelated Task(s)
Related PR(s)
Backport
Checklist: