Skip to content

Add Retry #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waigani wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Retry #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0aed69
Add Retry
waigani Oct 20, 2020
92d851a
tweak
waigani Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions diffparser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
package diffparser

import (
"context"
"regexp"
"strconv"
"strings"
"time"

"errors"
)
Expand Down Expand Up @@ -36,6 +38,25 @@ type DiffRange struct {
Lines []*DiffLine
}

func retry(ctx context.Context, f func() error) (int, error) {

attempt := 0
for delay := time.Millisecond; ; delay *= 2 {
attempt++
if err := f(); err == nil {
return attempt, nil
}
if delay >= 10*time.Second {
delay = 10 * time.Second
}
select {
case <-time.After(delay):
Copy link

@codelingo codelingo bot Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make one ticker as opposed to making a new timer each iteration.

View Rule

Copy link
Owner Author

@waigani waigani Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codelingo It'd be helpful if the comment explained a bit more of the why here: you're essentially avoiding a mem leak as a new timer object is created on each iteration.

Copy link

@codelingo codelingo bot Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply added to rule discussion thread

CodeLingoBot help

Copy link

@codelingo codelingo bot Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make one ticker as opposed to making a new timer each iteration.

View Rule

case <-ctx.Done():
return attempt, ctx.Err()
}
}
}

// DiffLineMode tells the line if added, removed or unchanged
type DiffLineMode rune

Expand Down