[#39] null as forced default value#40
Open
nagarajanchinnasamy wants to merge 2 commits intowankdanker:masterfrom
Open
[#39] null as forced default value#40nagarajanchinnasamy wants to merge 2 commits intowankdanker:masterfrom
nagarajanchinnasamy wants to merge 2 commits intowankdanker:masterfrom
Conversation
Owner
|
@nagarajanchinnasamy Please add tests exercising the proposed functionality. Thank you! |
Contributor
Author
|
You are welcome. I will add the tests and resubmit. |
Contributor
Author
|
Tests added. Please review. Thanks 👍 |
[wankdanker#39] null as forced default value [wankdanker#39] null as forced default value
nagarajanchinnasamy
force-pushed
the
master
branch
from
096413c to
50ae568
Compare
Contributor
Author
|
commits squashed into one. |
|
@nagarajanchinnasamy Did this ever get merged? I have same issue. One would expect a non-source key to never output |
|
Good question. Are you guys merging this one @wankdanker ? Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more details, please refer to issue: [#39] null as forced default value