Draft
Conversation
This bug was triggered for example when the connection closes (e.g. timeout) just as we attempt a new reuse of the connection. Returning 0, means the callers will make use of a now invalid WSI. This often results in a double free of the wsi memory. Need to return -1
lws-team
force-pushed
the
main
branch
2 times, most recently
from
07b1c27 to
a99b954
Compare
lws-team
force-pushed
the
main
branch
2 times, most recently
from
026710d to
9ba1504
Compare
lws-team
force-pushed
the
main
branch
4 times, most recently
from
fd918f2 to
207d634
Compare
lws-team
force-pushed
the
main
branch
12 times, most recently
from
6e43115 to
604765f
Compare
lws-team
force-pushed
the
main
branch
10 times, most recently
from
4a18968 to
c199714
Compare
lws-team
force-pushed
the
main
branch
9 times, most recently
from
aca2548 to
20263de
Compare
lws-team
force-pushed
the
main
branch
6 times, most recently
from
e028532 to
5867044
Compare
lws-team
force-pushed
the
main
branch
3 times, most recently
from
555e80f to
36ef2d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was triggered for example when the connection closes (e.g. timeout) just as we attempt a new reuse of the connection.
Returning 0, means the callers will make use of a now invalid WSI. This often results in a double free of the wsi memory.
Need to return -1