adjust ssl verification and options after context change#3317
Open
snar wants to merge 3 commits intowarmcat:mainfrom
Open
adjust ssl verification and options after context change#3317snar wants to merge 3 commits intowarmcat:mainfrom
snar wants to merge 3 commits intowarmcat:mainfrom
Conversation
Google's fuzzer platform blows a warning /src/libwebsockets/lib/plat/unix/unix-sockets.c:497:21: warning: implicit conversion loses integer precision: 'uint32_t' (aka 'unsigned int') to '__be16' (aka 'unsigned short') [-Wimplicit-int-conversion] 497 | sll.sll_protocol = (uint32_t)(htons((uint16_t)0x800));
3742e46 to
028931a
Compare
aca2548 to
20263de
Compare
e028532 to
5867044
Compare
36ef2d6 to
c9bf70c
Compare
e50f2bd to
10d3ba4
Compare
0f65cc9 to
c5ef352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for a well-known glitch in OpenSSL: when reassigning SSL to a different SSL_CTX certificates gets updated from a new context, but verification mode/depth and options are not updated.
Based on nginx implementation (https://mailman.nginx.org/pipermail/nginx-devel/2011-February/000728.html).