ESP-IDF: Removed explicit esp_task_wdt_reset call#3330
Open
vikramdattu wants to merge 3 commits intowarmcat:mainfrom
Open
ESP-IDF: Removed explicit esp_task_wdt_reset call#3330vikramdattu wants to merge 3 commits intowarmcat:mainfrom
esp_task_wdt_reset call#3330vikramdattu wants to merge 3 commits intowarmcat:mainfrom
Conversation
Google's fuzzer platform blows a warning /src/libwebsockets/lib/plat/unix/unix-sockets.c:497:21: warning: implicit conversion loses integer precision: 'uint32_t' (aka 'unsigned int') to '__be16' (aka 'unsigned short') [-Wimplicit-int-conversion] 497 | sll.sll_protocol = (uint32_t)(htons((uint16_t)0x800));
- Also removed some esp_wdt specific unnecessary header includes
Author
|
cc @Harshal5 |
|
@lws-team the libwebsockets library has been added as a managed component of esp-protocols, and merging this PR is crucial for us to move forward with adding other example codes, such as a server instance. |
Member
|
Can I suggest you take a more sensitive approach to what is already there than randomly ripping it out? It's not like what is there is so golden it must last a thousand years, but, there are users of the existing code such as Amazon. since it is enabled on AMAZON_FREERTOS currently, I think that should remain so for them. If you want to avoid what it is doing, then use a cmake define to override, defeating it or somesuch, rather than act like esp is the only user of it. |
lws-team
force-pushed
the
main
branch
23 times, most recently
from
14e29e7 to
1b15995
Compare
lws-team
force-pushed
the
main
branch
9 times, most recently
from
aca2548 to
20263de
Compare
lws-team
force-pushed
the
main
branch
6 times, most recently
from
e028532 to
5867044
Compare
lws-team
force-pushed
the
main
branch
4 times, most recently
from
36ef2d6 to
c9bf70c
Compare
lws-team
force-pushed
the
main
branch
9 times, most recently
from
e50f2bd to
10d3ba4
Compare
lws-team
force-pushed
the
main
branch
2 times, most recently
from
0f65cc9 to
c5ef352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is
esp_task_wdt_resetneeded?:Points under consideration while removing the call:
lws_service()function call is not unyielding, meaning, it does wait on socket select. Even if this function is called in a loop, it should be the caller's responsibility to yield or callesp_task_wdt_reset.taskYIELDesp_task_wdt_resetwithout callingesp_task_wdt_addhas no real use and only leads benign errors.