Skip to content

Fixed missing CRLF#3379

Open
PoltoS wants to merge 1 commit intowarmcat:mainfrom
PoltoS:fix-missing-crlf
Open

Fixed missing CRLF#3379
PoltoS wants to merge 1 commit intowarmcat:mainfrom
PoltoS:fix-missing-crlf

Conversation

@PoltoS
Copy link
Copy Markdown

@PoltoS PoltoS commented Apr 30, 2025

Partially reverts ef4a85d

Closes #3367

@PoltoS
Copy link
Copy Markdown
Author

PoltoS commented Jun 14, 2025

Hi @lws-team , could you please check this fix. The reasoning is in #3367

@lws-team
Copy link
Copy Markdown
Member

Yes I get it that something is up with this, however the code runs in different modes which act differently depending on if you have pm_deflate (and perhaps ws-over-h2) or not. I need to find the time to figure out the scope of it and try them all.

@roxlu
Copy link
Copy Markdown

roxlu commented Jul 27, 2025

Thanks @PoltoS and @lws-team, would be great if this gets fixed.

@lws-team
Copy link
Copy Markdown
Member

I can't reproduce it, as told here: #3367 (comment) Instructions for the case where there's a problem will help me solve it (whatever it is).

@PoltoS
Copy link
Copy Markdown
Author

PoltoS commented Jul 27, 2025

@lws-team In #3367 I shared my compilation parameters that lead to the issue with the current code. Doesn't it work for you to reproduce the issue? If not, please share on which system do you work? Maybe you can add this combination in CI/CD to check?

@lws-team lws-team force-pushed the main branch 5 times, most recently from c5ef352 to 46b045e Compare August 24, 2025 18:51
@lws-team lws-team force-pushed the main branch 8 times, most recently from 1faedc3 to efb9f35 Compare September 6, 2025 03:47
@lws-team lws-team force-pushed the main branch 3 times, most recently from a0c73c1 to 7c9d4bc Compare September 9, 2025 14:28
@lws-team lws-team force-pushed the main branch 12 times, most recently from a800d4a to 7f2f518 Compare September 18, 2025 08:03
@lws-team lws-team force-pushed the main branch 2 times, most recently from ab67a6b to baf4897 Compare October 1, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connection to WS server fails

3 participants