feat: pass workflow context as attachments by captainsafia · Pull Request #444 · warpdotdev/oz-for-oss

captainsafia · 2026-05-08T00:52:26Z

Summary

Cleaned up the outer-loop skills around explicit Inputs, Process, and Outputs sections.
Removed cloud-mode-specific and artifact-CLI-specific verbiage from skills so they stay execution-form agnostic.
Added Oz SDK attachment helpers and propagated attachments through workflow dispatch, webhook runtime wiring, and the Oz client.
Converted large/untrusted workflow context from inline prompt content to run attachments.
Removed low-value tests that asserted on literal prompt prose while preserving behavior and dispatch coverage.

Input mapping changes

PR review agent

pr_description_text is now provided as pr_description.md.
pr_diff_text is now provided as pr_diff.txt.
spec_context_text is now provided as spec_context.md.

Issue triage agent

issue_body is now provided as issue_body.md.
original_report is now provided as original_issue_report.md.
comments_text is now provided as issue_comments.md.
triggering_comment_text is now provided as triggering_comment.md.
triage_config is now provided as triage_config.json.
template_context is now provided as issue_template_context.json.

Respond-to-PR-comment agent

spec_context_text is now provided as spec_context.md.
PR body, conversation comments, review comments, the triggering comment, and PR diff remain fetched on demand through fetch_github_context.py, matching the existing model for that workflow.

Verify-PR agent

verification_skills_text is now provided as verification_skills.md.

Create-spec agent

issue_body is now provided as issue_body.md.
comments_text is now provided as issue_comments.md.
triggering_comment_text is now provided as triggering_comment.md.

Create-implementation and plan-approved agents

spec_context_text is now provided as spec_context.md.
Issue body, prior comments, and triggering comments remain fetched on demand through fetch_github_context.py, matching the existing implementation workflow model.

Validation

python3 -m pytest tests/test_attachments.py tests/test_dispatch.py tests/test_oz_client.py tests/test_webhook_dispatch.py tests/test_workflow_adapters.py tests/test_builders.py tests/test_triage.py tests/test_review_pr_reviewer_sampling.py
python3 -m pytest tests
git diff --check

Notes

The remaining inline prompt data is trusted/generated workflow metadata or instructions, such as branch names, labels, titles, co-author directives, and repo-local skill references.
Implementation plan: https://staging.warp.dev/drive/notebook/4ChSKaJXUTWnzWylCR40ql
Conversation: https://staging.warp.dev/conversation/e61faf6e-7484-43cd-aba2-2eb43024d1f0

Co-Authored-By: Oz oz-agent@warp.dev

Restructure outer-loop skills around inputs, process, and outputs, and remove cloud-mode-specific implementation verbiage so the skills stay execution-form agnostic. Co-Authored-By: Oz <oz-agent@warp.dev>

Add shared attachment helpers, propagate attachments through workflow dispatch and Oz SDK calls, and convert workflow prompts to reference attached context files instead of inlining large GitHub-backed inputs. Co-Authored-By: Oz <oz-agent@warp.dev>

Drop low-value tests that asserted on literal generated prompt prose while preserving behavior, routing, dispatch, and result-application coverage. Co-Authored-By: Oz <oz-agent@warp.dev>

oz-for-oss · 2026-05-08T00:52:37Z

@captainsafia

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR moves large workflow context into Oz run attachments and threads attachments through dispatch, webhook runtime, workflow prompts, and SDK client helpers.

Concerns

The result-file handoff was changed from explicit run artifact uploads to leaving files in the repository root, but the existing poll/apply code still loads named FILE artifacts from the run. This will prevent completed workflows from applying their review.json, triage_result.json, verification_report.json, or pr-metadata.json outputs unless artifact collection is updated or the upload instructions are restored.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

The poller consumes file outputs via load_artifact() / load_review_artifact(), which only polls FILE artifacts attached to the run. Leaving files at the repository root means successful runs will not be applied. Restores the 'oz artifact upload' (with 'oz-preview artifact upload' fallback) instructions in all 7 locations across 5 workflow files: - review_pr.py: review.json - verify_pr_comment.py: verification_report.json + media artifacts - create_spec_from_issue.py: pr-metadata.json - respond_to_pr_comment.py: pr-metadata.json + resolved_review_comments.json - triage_new_issues.py: triage_result.json - create_implementation_from_issue.py: pr-metadata.json Co-Authored-By: Oz <oz-agent@warp.dev>

captainsafia · 2026-05-08T03:43:02Z

/oz-review

oz-for-oss · 2026-05-08T03:43:15Z

@captainsafia

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR moves large workflow context from inline prompts into Oz run attachments and threads attachment payloads through dispatch, webhook wiring, workflow adapters, and the SDK client.

Concerns

Triage dispatch now creates six attachments, but the Oz SDK/API attachment schema documents a maximum of five per run, so triage runs can be rejected before an agent starts.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Co-Authored-By: Oz <oz-agent@warp.dev>

captainsafia · 2026-05-11T20:23:59Z

/oz-review

oz-for-oss · 2026-05-11T20:24:15Z

@captainsafia

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR moves large workflow context into Oz run attachments and updates dispatch/runtime plumbing to pass those attachments through.

Concerns

Several updated skills still tell agents to read the pre-migration context filenames (pr_description.txt or issue_comments.txt) while the dispatch prompts now attach pr_description.md and issue_comments.md. That mismatch can make agents skip PR descriptions or issue comment context in the affected workflows.

Verdict

Found: 0 critical, 4 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Co-Authored-By: Oz <oz-agent@warp.dev>

captainsafia · 2026-05-11T21:16:05Z

/oz-review

oz-for-oss · 2026-05-11T21:16:20Z

@captainsafia

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR moves large workflow context into Oz run attachments and threads attachment payloads through dispatch, webhook, workflow prompts, and the Oz client.

Security

New workflow context attachments can contain issue bodies, comments, and generated repository context, but most of the new scratch attachment filenames are not ignored, which makes accidental commits of untrusted or sensitive workflow context more likely.

Concerns

The review state payload still retains raw pr_body even though the PR description is now attachment-backed.
The verification skill tells agents to leave supporting files in paths described by the report, but the report schema has no artifact/path field.

Verdict

Found: 0 critical, 1 important, 2 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Co-Authored-By: Oz <oz-agent@warp.dev>

captainsafia · 2026-05-11T23:25:56Z

/oz-review

captainsafia · 2026-05-11T23:42:31Z

@vkodithala @peicodes I'm making this change to move us from embedding certain context directly in the prompt to using Oz's attachment functionality to resolve it. This should help make the prompts that we pass to the agent more concise and let the harness resolve additional information using attachments.

vkodithala · 2026-05-12T14:48:51Z

+__all__ = [
+    "DEFAULT_TEXT_ATTACHMENT_MIME_TYPE",
+    "SdkAttachment",
+    "text_attachment",
+]


OOC/for future reference: noticed that you're explicitly listing exports here, is this the pattern you're adopting for module files created in oz-for-oss, or is there a particular reason that you use __all__ here (since everything's exported)? Unimportant, but curious :)

This has mostly helped me with bookkeeping with of the methods defined here are actually referenced as a public surface area by the workflows. It's not the biggest value add since everything is publicly exported in this module anyways. I find it helps me with readability and identifying the key highlights from agent-generated code but we can remove it if it becomes crufty.

vkodithala

Read through your plan and went through the important codepaths, LGTM! Thanks for the fix!

Co-Authored-By: Oz <oz-agent@warp.dev>

captainsafia and others added 3 commits May 7, 2026 17:51

docs: clean up workflow skills

4089018

Restructure outer-loop skills around inputs, process, and outputs, and remove cloud-mode-specific implementation verbiage so the skills stay execution-form agnostic. Co-Authored-By: Oz <oz-agent@warp.dev>

test: remove prompt content assertions

8ee6310

Drop low-value tests that asserted on literal generated prompt prose while preserving behavior, routing, dispatch, and result-application coverage. Co-Authored-By: Oz <oz-agent@warp.dev>

oz-for-oss Bot reviewed May 8, 2026

View reviewed changes

Comment thread core/workflows/review_pr.py Outdated

oz-for-oss Bot reviewed May 8, 2026

View reviewed changes

Comment thread core/workflows/triage_new_issues.py Outdated

captainsafia and others added 3 commits May 11, 2026 13:11

chore: merge main into many tweaks

6891410

Co-Authored-By: Oz <oz-agent@warp.dev>

chore: merge remote branch updates

02347eb

Co-Authored-By: Oz <oz-agent@warp.dev>

fix: reduce triage attachment count

f6ac609

Co-Authored-By: Oz <oz-agent@warp.dev>

oz-for-oss Bot reviewed May 11, 2026

View reviewed changes

Comment thread .agents/skills/create-product-spec/SKILL.md Outdated

Comment thread .agents/skills/create-tech-spec/SKILL.md Outdated

fix: align skill attachment references

c3b8090

Co-Authored-By: Oz <oz-agent@warp.dev>

oz-for-oss Bot reviewed May 11, 2026

View reviewed changes

Comment thread .gitignore

Comment thread core/workflows/review_pr.py

Comment thread .agents/skills/verify-pr/SKILL.md Outdated

fix: address attachment review feedback

6ff0374

Co-Authored-By: Oz <oz-agent@warp.dev>

captainsafia requested review from peicodes and vkodithala May 11, 2026 23:39

vkodithala reviewed May 12, 2026

View reviewed changes

vkodithala approved these changes May 12, 2026

View reviewed changes

Comment thread oz/attachments.py Outdated

Comment thread core/workflows/attachments.py Outdated

fix: address PR feedback and merge main

58b787d

Co-Authored-By: Oz <oz-agent@warp.dev>

Conversation

captainsafia commented May 8, 2026

Summary

Input mapping changes

PR review agent

Issue triage agent

Respond-to-PR-comment agent

Verify-PR agent

Create-spec agent

Create-implementation and plan-approved agents

Validation

Notes

Uh oh!

oz-for-oss Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

captainsafia commented May 8, 2026

Uh oh!

oz-for-oss Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

captainsafia commented May 11, 2026

Uh oh!

oz-for-oss Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

Uh oh!

captainsafia commented May 11, 2026

Uh oh!

oz-for-oss Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Security

Concerns

Verdict

Uh oh!

Uh oh!

Uh oh!

Uh oh!

captainsafia commented May 11, 2026

Uh oh!

captainsafia commented May 11, 2026

Uh oh!

vkodithala May 12, 2026

Choose a reason for hiding this comment

Uh oh!

captainsafia May 13, 2026

Choose a reason for hiding this comment

Uh oh!

vkodithala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

oz-for-oss Bot commented May 8, 2026 •

edited

Loading

oz-for-oss Bot commented May 8, 2026 •

edited

Loading

oz-for-oss Bot commented May 11, 2026 •

edited

Loading

oz-for-oss Bot commented May 11, 2026 •

edited

Loading