Conversation
|
I wish I saw this.... lots of people are having issues with it here fatihak/InkyPi#167 |
|
It's fine. This just corrects some variable names, which doesn't affect how it works. |
interesting. but it is currently broken. we need to change the palette too then like I do here |
The palette is correct. This change affects epd7in3e which has 6 colors, as you said yourself in your previous message. The original author copied the epd7in3f code without properly renaming variables. This PR fixes that issue by correcting the naming to match epd7in3e and avoid confusion between drivers. Your pull request is incorrect because you are trying to use a 6-color palette on epd7in3f, which has 7 colors, including orange. 6 colors palette (epd7in3e): (0,0,0, 255,255,255, 255,255,0, 255,0,0, 0,0,255, 0,255,0) |
Updated code to match 6 colors specifics.
I also think there is an issue in epdconfig.py, where PWR_PIN should be 27 instead of 18 for Raspberry.
https://www.waveshare.com/wiki/7.3inch_e-Paper_HAT_(E)_Manual