Add compatibility for #[MapEntity] (Case 178313)
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of them is supposed to be extended and part of the bundle's API.
This event was introduced in Symfony 3.1 and matches our needs better: - We can get the controller action arguments in a more direct way and iterate over them only (typically fewer than request attributes) - We no longer need to care about the priority of our listener, as the ControllerArgumentsEvent is dispatched only after the arguments have been resolved - This allows us to get arguments resolved in other ways, e.g. via a MapEntity attribute
MalteWunsch
changed the title
#[MapEntity] (Case 178313)
Merge prerequisite section with first step, as they seemed redundant to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen to
ControllerArgumentsEventinstead ofControllerEvent. This event was introduced in Symfony 3.1 and matches our needs better:ControllerArgumentsEventis dispatched only after the arguments have been resolved#[MapEntity]attributeOther improvements: