sjpegi.h,Encoder: mark static const member as constexpr#136
Merged
jzern merged 1 commit intowebmproject:mainfrom Apr 29, 2025
Merged
sjpegi.h,Encoder: mark static const member as constexpr#136jzern merged 1 commit intowebmproject:mainfrom
jzern merged 1 commit intowebmproject:mainfrom
Conversation
This fixes the const declaration of `ALIGN_CST` which has an initial value, but is not technically a definition. Instead constexpr (which counts as a definition) is used. This fixes linker errors in some situations. PiperOrigin-RevId: 307131466
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the const declaration of
ALIGN_CSTwhich has an initialvalue, but is not technically a definition. Instead constexpr (which
counts as a definition) is used. This fixes linker errors in some
situations.
PiperOrigin-RevId: 307131466