update eslint and apply eslint-config-webpack #701
Conversation
eslint-config-webpack
|
@valscion resolved the |
valscion
left a comment
There was a problem hiding this comment.
Thanks! Tjis was easy to review as you had split many changes already to other PRs and this indeed was a a pure refactor.
What steps do you think are still to be done before these refactor steps are done?
|
@alexander-akait was this the last pull request around the refactoring? Would be nice to write down some information of these changes to changelog and link to all the PRs created. Especially #695 contains changes which do affect people as it changed |
|
@valscion Still work in progress, want to fix some issues in our code - resolve skip test and small refactor, due to the recent release, I had to spend more time on other tasks. I'll come back soon and of course add some changes. |
|
Sounds good! I'd like to do a release with minimal functionality changes to make upgrading for users of this library easier |
Summary
Adding
eslint-config-webpackand fix problem placesWhat kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing