Skip to content

update eslint and apply eslint-config-webpack #701

Merged
valscion merged 12 commits intomainfrom
more-eslint-improvements
Feb 7, 2026
Merged

update eslint and apply eslint-config-webpack #701
valscion merged 12 commits intomainfrom
more-eslint-improvements

Conversation

@alexander-akait
Copy link
Member

Summary

Adding eslint-config-webpack and fix problem places

What kind of change does this PR introduce?

refactor

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Nothing

@alexander-akait alexander-akait changed the title More eslint improvements update eslint and apply eslint-config-webpack Feb 2, 2026
@alexander-akait
Copy link
Member Author

@valscion resolved the lint step, ready for review

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tjis was easy to review as you had split many changes already to other PRs and this indeed was a a pure refactor.

What steps do you think are still to be done before these refactor steps are done?

@valscion valscion merged commit be761ef into main Feb 7, 2026
5 checks passed
@valscion valscion deleted the more-eslint-improvements branch February 7, 2026 14:07
@valscion
Copy link
Member

@alexander-akait was this the last pull request around the refactoring? Would be nice to write down some information of these changes to changelog and link to all the PRs created.

Especially #695 contains changes which do affect people as it changed dependencies and upgraded at least one package. #700 would also be nice to mention as now we use more modern JS in the source code and that could have implications for people running on versions of Node.js we no longer officially support.

@alexander-akait
Copy link
Member Author

@valscion Still work in progress, want to fix some issues in our code - resolve skip test and small refactor, due to the recent release, I had to spend more time on other tasks. I'll come back soon and of course add some changes.

@valscion
Copy link
Member

Sounds good! I'd like to do a release with minimal functionality changes to make upgrading for users of this library easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments