feat: enable cacheImmutable by default #2247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #2247 +/- ##
==========================================
+ Coverage 95.83% 95.86% +0.03%
==========================================
Files 13 13
Lines 888 895 +7
Branches 259 264 +5
==========================================
+ Hits 851 858 +7
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (cacheControl.immutable) { | ||
| if (cacheControl.immutable !== false && hasCacheImmutable) { | ||
| cacheControlValue += ", immutable"; | ||
| } |
Member
There was a problem hiding this comment.
Can we refactor this place? Convert boolean/number/string to object value to avoid logic duplication?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cacheImmutable
becomestrue` by default, which seems pretty good to me.What kind of change does this PR introduce?
feat
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
yes
If relevant, what needs to be documented once your changes are merged or what have you already documented?