Skip to content

Fix props type definition for React 18#121

Open
greeeg wants to merge 1 commit intowebraptor:masterfrom
greeeg:master
Open

Fix props type definition for React 18#121
greeeg wants to merge 1 commit intowebraptor:masterfrom
greeeg:master

Conversation

@greeeg
Copy link
Copy Markdown

@greeeg greeeg commented Nov 2, 2023

This PR fixes an issue related to using this component in a project with React 18 where the children prop is not included by default by the Component class, causing the following error:

Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Swiper> & Readonly<{}>'

@wr1159
Copy link
Copy Markdown

wr1159 commented Jul 21, 2025

Are there any problems with this PR, I am facing the same problem and think this should be merged

@webraptor
Copy link
Copy Markdown
Owner

@greeeg @wr1159 in order to get this merged and release, please bump the package's patch version and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants