Layer legend wms styles support#481
Merged
fschmenger merged 3 commits intoApr 28, 2026
Merged
Conversation
chrismayer
approved these changes
Apr 27, 2026
Collaborator
chrismayer
left a comment
chrismayer
left a comment
There was a problem hiding this comment.
Thanks for this @fschmenger. Very useful extension. LGTM, also tested in example apps.
Collaborator
Author
|
Hi @chrismayer. Thanks for the review - will merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR extends the layer legend implementation to forward the WMS
STYLESparameter intoGetLegendGraphicrequests. Reactivity was added, such that the legend image is re-rendered when new styles are assigned to the WMS source.