fix: chess/discovery builds — add http.capnp, remove stale IPFS dep (v0.0.4.1)#333
Merged
fix: chess/discovery builds — add http.capnp, remove stale IPFS dep (v0.0.4.1)#333
Conversation
stem.capnp imports http.capnp for the HttpClient graft field, but chess and discovery didn't compile it. Also removes the chess example's dependency on get_ipfs() (removed from graft response per UnixFS consolidation). Replay publishing is now a local log. Removes make run-daemon — after make, run the binary directly: target/release/ww run crates/kernel std/shell
Adversarial review found: ipfs_capnp module compiled but unused (stem.capnp doesn't import ipfs.capnp), and play_rpc_game doc comment still claimed IPFS publishing.
lthibault
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stem.capnpimportshttp.capnpfor the HttpClient graft field, but chess and discovery didn't compile it. Added to both build scripts.get_ipfs()on the graft response (field removed after UnixFS consolidation). Replaced IPFS replay publishing with local debug logging.ipfs_capnpmodule andipfs.capnpcompilation from chess and discovery (stem.capnp doesn't import it). Fixed stale doc comment claiming IPFS publishing.make run-daemon(usetarget/release/ww run crates/kernel std/shelldirectly aftermake)Pre-Landing Review
No issues found.
Adversarial Review
Claude subagent found 3 fixable items (dead ipfs_capnp, stale doc comment, dead prev_cid chain). First two fixed. prev_cid chain left as-is (harmless, will be cleaned in a future replay refactor).
Test plan
make chesspassesmake discoverypassesmake oraclepassesinjectfeature)