Skip to content

Bug fix: Possible solution for accurate title text on Donation Reminder - #6149

Closed
Williamrai wants to merge 8 commits into
mainfrom
possible-donation-reminder-article-visit-bug-fix
Closed

Bug fix: Possible solution for accurate title text on Donation Reminder #6149
Williamrai wants to merge 8 commits into
mainfrom
possible-donation-reminder-article-visit-bug-fix

Conversation

@Williamrai

@Williamrai Williamrai commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator

What does this do?

  • adds a new variable continuousArticleVisit for tracking continuous article visit per milestone
  • extract logic from shouldShowReminderNow() to a new function recordReminderShown() which will be called after UI has updated
  • update logic to show accurate titleText

@Williamrai
Williamrai requested a review from voyagerfan as a code owner August 13, 2026 16:59
@Williamrai

Williamrai commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this since we haven’t seen any similar issues occur.

@Williamrai Williamrai closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cooltey cooltey Awaiting requested review from cooltey cooltey is a code owner
@dbrant dbrant Awaiting requested review from dbrant dbrant is a code owner
@voyagerfan voyagerfan Awaiting requested review from voyagerfan voyagerfan is a code owner

Assignees

No one assigned

Labels

Bug Bug DO NOT MERGE Do not merge Ready for Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Williamrai